lby/lk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[display] Fix corruption in color lcd update.

Browse Source 
Suspect a timing issue related to the trailer bits.
Preparing the trailers together with the data seems to resolve
the corruption.

R=gkalsi@google.com

Review URL: https://codereview.chromium.org/1777653003 .
This commit is contained in:
cstout
2016-03-09 11:10:57 -08:00
parent d22f8054c9
commit e290cb1b8b
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
target/dartuinoP0/memory_lcd.c
View File

@@ -122,6 +122,7 @@ static void mlcd_flush(uint starty, uint endy)
static uint8_t localbuf[MLCD_BUF_SIZE];
uint8_t *bufptr = localbuf;
uint8_t trailer = 0;
// The first line is preceeded with a write command.
*bufptr++ = MLCD_WR | vcom_state;
@@ -134,21 +135,20 @@ static void mlcd_flush(uint starty, uint endy)
bufptr += lcd_get_line(framebuffer, j, bufptr);
// 8 bit trailer per line
*bufptr++ = trailer;
if (j == endy) {
// 16 bit trailer on the last line
*bufptr++ = trailer;
}
if (HAL_SPI_Transmit(&SpiHandle, localbuf, bufptr - localbuf, HAL_MAX_DELAY) != HAL_OK) {
goto finish;
}
bufptr = localbuf;
*bufptr++ = (j + 1);
}
uint8_t trailer = 0;
if (HAL_SPI_Transmit(&SpiHandle, &trailer, 1, HAL_MAX_DELAY) != HAL_OK) {
goto finish;
}
finish:
chip_select(false);
}