lby/lk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[display] Refactor to avoid implicit framebuffer allocation.

Browse Source 
Preparation to allow other images to be presented to the display.
Separate definitions of display and image formats.
display_get_info no longer provides a framebuffer.
display_get_framebuffer allocates a framebuffer for convenience.

Review URL: https://codereview.chromium.org/1777783003 .
This commit is contained in:
cstout
2016-03-10 09:49:22 -08:00
parent e290cb1b8b
commit c1255f7f47
16 changed files with 333 additions and 172 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
target/qemu-m4/m4display.c
View File

@@ -34,8 +34,8 @@
#include <dev/display.h>
#include <dev/gpio.h>
#include <lib/gfx.h>
#include <platform/gpio.h>
#include <assert.h>
#define LOCAL_TRACE 0
@@ -202,16 +202,31 @@ static void s4lcd_flush(uint starty, uint endy)
chip_select(true);
}
status_t display_get_info(struct display_info *info)
status_t display_get_framebuffer(struct display_framebuffer *fb)
{
LTRACEF("display_info %p\n", info);
DEBUG_ASSERT(fb);
LTRACEF("display_get_framebuffer %p\n", fb);
info->framebuffer = (void *)framebuffer;
info->format = GFX_FORMAT_RGB_2220;
info->width = M4DISPLAY_WIDTH;
info->height = M4DISPLAY_HEIGHT;
info->stride = M4DISPLAY_WIDTH;
info->flush = s4lcd_flush;
fb->image.pixels = (void *)framebuffer;
fb->image.format = IMAGE_FORMAT_RGB_2220;
fb->image.width = M4DISPLAY_WIDTH;
fb->image.height = M4DISPLAY_HEIGHT;
fb->image.stride = M4DISPLAY_WIDTH;
fb->image.rowbytes = M4DISPLAY_WIDTH;
fb->flush = s4lcd_flush;
fb->format = DISPLAY_FORMAT_UNKNOWN; //TODO
return NO_ERROR;
}
status_t display_get_info(struct display_info *info)
{
DEBUG_ASSERT(info);
LTRACEF("display_info %p\n", info);
info->format = DISPLAY_FORMAT_UNKNOWN; //TODO
info->width = M4DISPLAY_WIDTH;
info->height = M4DISPLAY_HEIGHT;
return NO_ERROR;
}