lby/lk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[kernel] fix bug in event_signal with AUTOUNSIGNAL flag

Browse Source 
Would not mark the event as unsignalled before potentially
releasing any waiting threads, which would let them fall through
event_wait until the signalling thread was run again.
This commit is contained in:
Travis Geiselbrecht
2009-01-20 00:24:27 -08:00
committed by Travis Geiselbrecht
parent 09eeebda43
commit bb777a15de
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
kernel/event.c
View File

@@ -99,13 +99,19 @@ status_t event_signal(event_t *e, bool reschedule)
#endif
if (!e->signalled) {
e->signalled = true;
if (e->flags & EVENT_FLAG_AUTOUNSIGNAL) {
/* try to release one thread and unsignal again if successful */
if (wait_queue_wake_one(&e->wait, reschedule, NO_ERROR) > 0)
e->signalled = false;
/* try to release one thread and leave unsignalled if successful */
if (wait_queue_wake_one(&e->wait, reschedule, NO_ERROR) <= 0) {
/*
* if we didn't actually find a thread to wake up, go to
* signalled state and let the next call to event_wait
* unsignal the event.
*/
e->signalled = true;
}
} else {
/* release all threads and remain signalled */
e->signalled = true;
wait_queue_wake_all(&e->wait, reschedule, NO_ERROR);
}
}