From a895bcece529da912ebc8c46f3ee8428bc5c8f93 Mon Sep 17 00:00:00 2001
From: Travis Geiselbrecht <travisg@gmail.com>
Date: Thu, 21 Oct 2021 23:14:27 -0700
Subject: [PATCH] [kernel][warnings] fix a few -Wmissing-declarations warnings
 in the kernel

---
 kernel/include/kernel/init.h | 11 +++++++++++
 kernel/init.c                |  2 ++
 kernel/novm/novm.c           |  2 +-
 kernel/thread.c              |  2 +-
 top/main.c                   |  3 +--
 5 files changed, 16 insertions(+), 4 deletions(-)
 create mode 100644 kernel/include/kernel/init.h

diff --git a/kernel/include/kernel/init.h b/kernel/include/kernel/init.h
new file mode 100644
index 00000000..879c2c17
--- /dev/null
+++ b/kernel/include/kernel/init.h
@@ -0,0 +1,11 @@
+/*
+ * Copyright (c) 2021 Travis Geiselbrecht
+ *
+ * Use of this source code is governed by a MIT-style
+ * license that can be found in the LICENSE file or at
+ * https://opensource.org/licenses/MIT
+ */
+#pragma once
+
+void kernel_init(void);
+
diff --git a/kernel/init.c b/kernel/init.c
index 32766169..0a8432a7 100644
--- a/kernel/init.c
+++ b/kernel/init.c
@@ -5,6 +5,8 @@
  * license that can be found in the LICENSE file or at
  * https://opensource.org/licenses/MIT
  */
+#include <kernel/init.h>
+
 #include <kernel/debug.h>
 #include <kernel/mp.h>
 #include <kernel/port.h>
diff --git a/kernel/novm/novm.c b/kernel/novm/novm.c
index 86a3e0c0..0c2996ba 100644
--- a/kernel/novm/novm.c
+++ b/kernel/novm/novm.c
@@ -152,7 +152,7 @@ static void novm_init(uint level) {
 LK_INIT_HOOK(novm, &novm_init, LK_INIT_LEVEL_PLATFORM_EARLY - 1);
 #endif
 
-void *novm_alloc_helper(struct novm_arena *n, size_t pages) {
+static void *novm_alloc_helper(struct novm_arena *n, size_t pages) {
     if (pages == 0 || pages > n->pages)
         return NULL;
 
diff --git a/kernel/thread.c b/kernel/thread.c
index 0b3ddf23..5427d1f8 100644
--- a/kernel/thread.c
+++ b/kernel/thread.c
@@ -108,7 +108,7 @@ static void wakeup_cpu_for_thread(thread_t *t)
         mp_reschedule(1U << pinned_cpu, 0);
 }
 
-void init_thread_struct(thread_t *t, const char *name) {
+static void init_thread_struct(thread_t *t, const char *name) {
     memset(t, 0, sizeof(thread_t));
     t->magic = THREAD_MAGIC;
     thread_set_pinned_cpu(t, -1);
diff --git a/top/main.c b/top/main.c
index c2326e9f..5d19fa5f 100644
--- a/top/main.c
+++ b/top/main.c
@@ -14,6 +14,7 @@
 
 #include <app.h>
 #include <arch.h>
+#include <kernel/init.h>
 #include <kernel/mutex.h>
 #include <kernel/novm.h>
 #include <kernel/thread.h>
@@ -40,8 +41,6 @@ static uint secondary_bootstrap_thread_count;
 
 static int bootstrap2(void *arg);
 
-extern void kernel_init(void);
-
 static void call_constructors(void) {
     void **ctor;