From 7643bc28c3a99108a85828f1796f1bc3b07ddde5 Mon Sep 17 00:00:00 2001
From: Travis Geiselbrecht <geist@foobox.com>
Date: Wed, 19 Jun 2013 14:21:53 -0700
Subject: [PATCH] [make] add -Wstrict-prototypes and clean up old C style
 prototypes

replace all built versions of foo(); with foo(void);
---
 app/tests/thread_tests.c    | 4 ++--
 arch/arm/include/arch/arm.h | 2 +-
 engine.mk                   | 2 +-
 kernel/main.c               | 2 +-
 platform/armemu/debug.c     | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/app/tests/thread_tests.c b/app/tests/thread_tests.c
index 7ebcd525..494b7241 100644
--- a/app/tests/thread_tests.c
+++ b/app/tests/thread_tests.c
@@ -55,7 +55,7 @@ static int sem_remaining_its = 0;
 static int sem_threads = 0;
 static mutex_t sem_test_mutex;
 
-static int semaphore_producer()
+static int semaphore_producer(void *unused)
 {
 	printf("semaphore producer %p starting up, running for %d iterations\n", current_thread, sem_total_its);
 
@@ -66,7 +66,7 @@ static int semaphore_producer()
 	return 0;
 }
 
-static int semaphore_consumer()
+static int semaphore_consumer(void *unused)
 {
 	unsigned int iterations = 0;
 
diff --git a/arch/arm/include/arch/arm.h b/arch/arm/include/arch/arm.h
index 21856ffb..1b0331a2 100644
--- a/arch/arm/include/arch/arm.h
+++ b/arch/arm/include/arch/arm.h
@@ -34,7 +34,7 @@ __BEGIN_CDECLS
 
 void arm_context_switch(vaddr_t *old_sp, vaddr_t new_sp);
 
-static inline uint32_t read_cpsr()
+static inline uint32_t read_cpsr(void)
 {
 	uint32_t cpsr;
 
diff --git a/engine.mk b/engine.mk
index 3ad594b4..73803469 100644
--- a/engine.mk
+++ b/engine.mk
@@ -46,7 +46,7 @@ CONFIGHEADER := $(BUILDDIR)/config.h
 GLOBAL_INCLUDES := $(BUILDDIR) $(LKROOT)/include $(addsuffix /include,$(LKINC))
 GLOBAL_OPTFLAGS ?= -Os
 GLOBAL_COMPILEFLAGS := -g -finline -W -Wall -Wno-multichar -Wno-unused-parameter -Wno-unused-function -include $(CONFIGHEADER)
-GLOBAL_CFLAGS := --std=gnu99 -Werror-implicit-function-declaration
+GLOBAL_CFLAGS := --std=gnu99 -Werror-implicit-function-declaration -Wstrict-prototypes
 #GLOBAL_CFLAGS += -Werror
 GLOBAL_CPPFLAGS := -fno-exceptions -fno-rtti -fno-threadsafe-statics
 #GLOBAL_CPPFLAGS += -Weffc++
diff --git a/kernel/main.c b/kernel/main.c
index 31a63f1a..1c6295d0 100644
--- a/kernel/main.c
+++ b/kernel/main.c
@@ -50,7 +50,7 @@ static void call_constructors(void)
 	while (ctor != &__ctor_end) {
 		void (*func)(void);
 
-		func = (void (*)())*ctor;
+		func = (void (*)(void))*ctor;
 
 		func();
 		ctor++;
diff --git a/platform/armemu/debug.c b/platform/armemu/debug.c
index 935e9213..1c2a5603 100644
--- a/platform/armemu/debug.c
+++ b/platform/armemu/debug.c
@@ -93,7 +93,7 @@ void debug_set_trace_level(int trace_type, int level)
 	*REG32(DEBUG_SET_TRACELEVEL_CPU + trace_type * 4) = level;
 }
 
-uint32_t debug_cycle_count()
+uint32_t debug_cycle_count(void)
 {
 	return *REG32(DEBUG_CYCLE_COUNT);
 }