lby/lk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[make] [lib/version] remove a misplaced .PHONY (#170)

Browse Source 
When lib/version was included, a rule depended on .PHONY.  This would
unexpectedly invoke other rules defined as dependent on .PHONY (standard
phony-ness signal).

As a side effect, this used to generate srcfiles.txt and
include_paths.txt in build dir. Since they are useful, we might always
build those anyway, and not make them phony at all.
This commit is contained in:
Girts
2016-10-07 11:24:29 -07:00
committed by Travis Geiselbrecht
parent 9a2fcf2b60
commit 3972b18697
3 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/version/rules.mk
View File

@@ -16,13 +16,14 @@ BUILDID := "$(shell $(LOCAL_DIR)/buildid.sh)_LOCAL"
endif
endif
# Generate a buildid.h file, lazy evaulated BUILDID_DEFINE at the end
# Generate a buildid.h file, lazy evaluate BUILDID_DEFINE at the end
# of the first make pass. This lets modules that haven't been
# included yet set BUILDID.
BUILDID_DEFINE="BUILDID=\"$(BUILDID)\""
BUILDID_H := $(BUILDDIR)/buildid.h
$(BUILDID_H): .PHONY
$(BUILDID_H):
@$(call MAKECONFIGHEADER,$@,BUILDID_DEFINE)
.PHONY: $(BUILDID_H)
GENERATED += $(BUILDID_H)